[report-converter] Allow for empty strings in sanitizer error msgs #4147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes, memory addresses will simply be omitted from the sanitizer error messages. In this case, ` .+ ` will not match the error message, since this matches strings with the minimum length of 3, but the address-less message usually looks like this: `error on adress , because`, with only 2 characters there. The fix is simple -- simply change `.+` zo `.*`. I also added generic messages to asan, because we were missing that.
bruntib
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, memory addresses will simply be omitted from the sanitizer error messages. In this case,
.+will not match the error message, since this matches strings with the minimum length of 3, but the address-less message usually looks like this:error on adress , because, with only 2 characters there. The fix is simple -- simply change.+zo.*.I also added generic messages to asan, because we were missing that.