-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Evaluate method to DTP proxy #12
Conversation
...which matches the following line: func (m *MockClient) Solve(arg0 context.Context, arg1 client.SolveRequest) (*result.Result[github.com/moby/buildkit/frontend/gateway/client.Reference], error) { Seems like |
@EricHripko Looks like mockgen has been updated finally -- uber-go/mock#13 Any chance you have some cycles to get this change landed? |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #12 +/- ##
==========================================
- Coverage 90.86% 89.74% -1.13%
==========================================
Files 5 5
Lines 219 273 +54
==========================================
+ Hits 199 245 +46
- Misses 16 24 +8
Partials 4 4 ☔ View full report in Codecov by Sentry. |
Overview
This PR add
Evaluate
method and upgrades Buildkit from0.10.0
to0.11.2
.Other changes
golang/mock
togo.uber.org/mock/gomock
, which is a newer fork that supports mocking genericscodecov/codecov-action
tov4
, as old one appears to have stopped working