Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Evaluate method to DTP proxy #12

Merged
merged 4 commits into from
May 2, 2024
Merged

Add Evaluate method to DTP proxy #12

merged 4 commits into from
May 2, 2024

Conversation

EricHripko
Copy link
Owner

@EricHripko EricHripko commented Feb 6, 2023

Overview

This PR add Evaluate method and upgrades Buildkit from 0.10.0 to 0.11.2.

Other changes

  • Move from golang/mock to go.uber.org/mock/gomock, which is a newer fork that supports mocking generics
  • Upgrade codecov/codecov-action to v4, as old one appears to have stopped working

@EricHripko
Copy link
Owner Author

mockgen currently fails on the following:

2023/02/06 11:40:16 Failed to format generated source code: mock/client.go:102:102: missing ',' in type argument list (and 1 more errors)

...which matches the following line:

func (m *MockClient) Solve(arg0 context.Context, arg1 client.SolveRequest) (*result.Result[github.com/moby/buildkit/frontend/gateway/client.Reference], error) {

Seems like mockgen currently is not able to handle generics, golang/mock#669 should fix (although it's been open for nearly 8 months 😬

@ashb
Copy link
Contributor

ashb commented Apr 16, 2024

@EricHripko Looks like mockgen has been updated finally -- uber-go/mock#13 Any chance you have some cycles to get this change landed?

Copy link

github-actions bot commented May 2, 2024

Unit Test Results

63 tests   63 ✔️  5s ⏱️
  6 suites    0 💤
  1 files      0

Results for commit 024f886.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 89.74%. Comparing base (566a585) to head (024f886).
Report is 2 commits behind head on main.

Files Patch % Lines
pkg/dtp/proxy.go 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
- Coverage   90.86%   89.74%   -1.13%     
==========================================
  Files           5        5              
  Lines         219      273      +54     
==========================================
+ Hits          199      245      +46     
- Misses         16       24       +8     
  Partials        4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EricHripko EricHripko merged commit a127dcf into main May 2, 2024
5 checks passed
@EricHripko EricHripko deleted the add-evaluate branch May 2, 2024 08:45
@EricHripko
Copy link
Owner Author

@ashb thank you for the ping and sorry for the delay! This should now be available via v0.3.0 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants