Initial implementation of stepping back on Windows #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donadigo
changed the title
|
Can't wait for this to be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial implementation of saving previous steps when stepping through the process on Windows.
The command is available in the Control -> Step back menu. This feature works similarly to what is implemented in Visual Studio Enterprise. If you stepped through a specific line, you'll be able to step back to it and inspect all locals and call stack (even the objects that were not expanded before, or with different view rules). The snapshots are released once the target enters run state again (continue).
Internally, a new entity kind is created in df and demon that represents a snapshot. Snapshots are children of threads and are created using
PssCaptureSnapshotwhich greatly simplifies the implementation as Windows takes care of doing all of the copy-on-write work that's required to preserve the state. Once a snapshot is activated, we just change the entity we are reading from.Things to check: