fix(stores): getCountryCodes returns codes sorted (#101)

Ephigenia · Apr 17, 2022 · d39cd0d · d39cd0d
1 parent 0b5c143
commit d39cd0d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/source/lib/stores.js b/source/lib/stores.js
@@ -70,11 +70,12 @@ module.exports = {
 
   /**
    * Returns an array with all ISO 3166-1 alpha 2 country codes that have at
-   * least one store.
+   * least one store in alphabetical order.
    * @returns {string[]} two-letter ISO 3166-2 alpha 2 country codes
    */
   getCountryCodes: function() {
-    return Array.from(new Set(data.map(store => store.countryCode)));
+    return Array.from(new Set(data.map(store => store.countryCode)))
+      .sort((a, b) => a.localeCompare(b));
   },
 
   /**

diff --git a/source/lib/stores.test.js b/source/lib/stores.test.js
@@ -91,9 +91,11 @@ describe('stores', function() {
   }); // getLanguageCode
 
   describe('getCountryCodes', function() {
-    it('returns an array of supported country codes', () => {
+    it('returns an array of ordered supported country codes', () => {
       const codes = stores.getCountryCodes();
       expect(codes.length).to.be.gte(1);
+      expect(codes[0]).to.equal('at');
+      expect(codes[1]).to.equal('au');
     });
   }); // getCountryCodes
 }); // suite