fix unnecessary looping by stopping when cfraction crosses one #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaacdoidge
requested changes
Sep 20, 2024
aptos-move/framework/supra-framework/sources/pbo_delegation_pool.move
Outdated
Show resolved
Hide resolved
isaacdoidge
approved these changes
Sep 20, 2024
nizam-supraoracles
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
can_unlock_principlethe loop keeps looping even thoughcfractionmight have become greater than one. That is just unnecessary waste and in cases where a long time has elapsed (cliff is lesser, period is lesser but very long time has elapsed) in that case this loop would exceed execution limit. As it is there is no utility in looping after unlocked fraction crosses1.