Remove unused delegation_pool module from supra_framework
#67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjoshisupra
approved these changes
Sep 6, 2024
sjoshisupra
requested changes
Sep 6, 2024
crates/aptos-rosetta/src/client.rs
Outdated
| AccountIdentifier::base_account(pool_address), | ||
| amount, | ||
| )]; | ||
| let operations = vec![]; |
There was a problem hiding this comment.
When this vector is empty, no operation is performed. Doesn't this mean that the test is practically removed?
There was a problem hiding this comment.
Okay, Actually we need to remove entire test for delegation pool module from aptos-rosetta.
I made the changes
crates/aptos-rosetta/src/client.rs
Outdated
| AccountIdentifier::base_account(pool_address), | ||
| amount, | ||
| )]; | ||
| let operations = vec![]; |
| AccountIdentifier::base_account(pool_address), | ||
| Some(amount), | ||
| )]) | ||
| Ok(vec![]) |
| AccountIdentifier::base_account(pool_address), | ||
| Some(amount), | ||
| )]) | ||
| Ok(vec![]) |
| AccountIdentifier::base_account(pool_address), | ||
| Some(amount), | ||
| )]) | ||
| Ok(vec![]) |
… replace delegation pool functions as pbo_delegation_pool
nizam-supraoracles
force-pushed
the
clean/unused_modules
branch
from
86d65e8
to
803f06a
Compare
sjoshisupra
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
delegation_poolmodule from supra_framework.