-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused delegation_pool
module from supra_framework
#67
Conversation
crates/aptos-rosetta/src/client.rs
Outdated
AccountIdentifier::base_account(pool_address), | ||
amount, | ||
)]; | ||
let operations = vec![]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When this vector is empty, no operation is performed. Doesn't this mean that the test is practically removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, Actually we need to remove entire test for delegation pool module from aptos-rosetta
.
I made the changes
crates/aptos-rosetta/src/client.rs
Outdated
AccountIdentifier::base_account(pool_address), | ||
amount, | ||
)]; | ||
let operations = vec![]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above.
AccountIdentifier::base_account(pool_address), | ||
Some(amount), | ||
)]) | ||
Ok(vec![]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above.
AccountIdentifier::base_account(pool_address), | ||
Some(amount), | ||
)]) | ||
Ok(vec![]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above
AccountIdentifier::base_account(pool_address), | ||
Some(amount), | ||
)]) | ||
Ok(vec![]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above
… replace delegation pool functions as pbo_delegation_pool
86d65e8
to
803f06a
Compare
delegation_pool
module from supra_framework.