add assertion to check existence of shareholder in the contract #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjoshisupra
requested review from
nizam-supraoracles,
anshuman-supraoracles and
axiongsupra
addressed in the new commit |
nizam-supraoracles
approved these changes
Jul 11, 2024
axiongsupra
reviewed
Jul 11, 2024
| @@ -383,17 +383,19 @@ module supra_framework::vesting_without_staking { | |||
| } | |||
|
|
|||
| public entry fun vest_individual(contract_address: address, shareholder_address: address) acquires VestingContract { | |||
| assert_active_vesting_contract(contract_address); | |||
There was a problem hiding this comment.
@sjoshisupra why we removed this check as the vesting contract can be terminated at the end of vest_individual. It will cause a problem when call vest method who will call vest_individual in a loop.
move termination logic to `vest` instead of `vest_individual`. This is done to prevent following from happening: If 5 shareholders are there and only 2 have non-zero balance when `vest` is called after these 2 get their vesting due, if `vest_individual` sets the termination flag, in the loop when `vest_individual` is called for 3rd shareholder assertion will fail and the whole Tx will abort.
axiongsupra
approved these changes
Jul 16, 2024
nizam-supraoracles
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add assertion to check that a shareholder exist in the contract as a precondition to
vest_individualto avoid failure insimple_map::borrow.