Traits for supra cli #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so-kkroy22
commented
Jul 8, 2024
•
so-kkroy22
commented
- https://github.com/Entropy-Foundation/smr-moonshot/issues/538
- https://github.com/Entropy-Foundation/smr-moonshot/pull/577
- Traits for supra cli #24
sjoshisupra
requested changes
Jul 9, 2024
so-schen
reviewed
Jul 10, 2024
sjoshisupra
requested changes
Jul 18, 2024
| const SUPRA_FRAMEWORK: &str = "SupraFramework"; | ||
| const SUPRA_FRAMEWORK_GIT_PATH: &str = "https://github.com/Entropy-Foundation/aptos-core.git"; | ||
| const SUBDIR_PATH: &str = "aptos-move/framework/supra-framework"; | ||
| const DEFAULT_BRANCH: &str = "integrate_consensus_key"; |
There was a problem hiding this comment.
Can we refactor somehow so that name of the branch/path/repo etc, instead of being hardcoded in the repo, is in some config file?
There was a problem hiding this comment.
As per the discussion this change can be skipped as we do not want user to play with this config.
sjoshisupra
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.