Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Traits for supra cli #24

Merged
merged 7 commits into from
Jul 22, 2024
Merged

Traits for supra cli #24

merged 7 commits into from
Jul 22, 2024

Conversation

crates/aptos/src/move_tool/mod.rs Outdated Show resolved Hide resolved
crates/aptos/src/move_tool/mod.rs Outdated Show resolved Hide resolved
@@ -0,0 +1,18 @@
// Copyright © Aptos Foundation

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be Entropy Foundation

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done here 0d32df2

const SUPRA_FRAMEWORK: &str = "SupraFramework";
const SUPRA_FRAMEWORK_GIT_PATH: &str = "https://github.com/Entropy-Foundation/aptos-core.git";
const SUBDIR_PATH: &str = "aptos-move/framework/supra-framework";
const DEFAULT_BRANCH: &str = "integrate_consensus_key";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we refactor somehow so that name of the branch/path/repo etc, instead of being hardcoded in the repo, is in some config file?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per the discussion this change can be skipped as we do not want user to play with this config.

@so-kkroy22 so-kkroy22 merged commit 832a0de into integrate_consensus_key Jul 22, 2024
1 check passed
@so-kkroy22 so-kkroy22 deleted the supra-cli branch July 22, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants