Rc june 2024 #92
Merged
Rc june 2024 #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikewallace1979
approved these changes
Jun 28, 2024
barthisrael
requested changes
Jun 28, 2024
There was a problem hiding this comment.
Besides the comment left in the changed files, as discussed in Slack I think we should just ignore Pyright errors for now (by setting # pyright: ignore [reportCallIssue] on both exec_diagnose lines) so we unblock the release for now.
Ideally that should've been implemented in a different way, so we wouldn't need to silence pyright. I mean, by using logic which depends on the Barman module version instead of on an AttributeError Exception. But changing that now would require some time to change the code, change the tests, perform tests again, ...
gonzalemario
force-pushed
the
rc-june-2024
branch
from
0e47f3c
to
20fa7e7
Compare
barthisrael
requested changes
Jun 28, 2024
gonzalemario
force-pushed
the
rc-june-2024
branch
from
20fa7e7
to
7526606
Compare
gonzalemario
force-pushed
the
rc-june-2024
branch
from
7526606
to
80217f6
Compare
barthisrael
requested changes
Jun 28, 2024
`pyright` was complaining about the `exec_diagnose`. That issue occurs because based on the Barman module version that is installed in the virtual environemnt, the signature of that method would have either 2 or 4 parameters. We had 2 options to handle that issue: * Add `pyright: ignore` directives to the source code where `exec_diagnose` is called; or * Change the implementation so instead of relying on `AttributeError` exception, it would handle the version for the Barman module. We chose the first option for now, so we unblock the release. The code with `AttributeError` exception has already been tested. If we were to go with the second option now, that would require changing the code, changing the unit tests and performing more tests, thus dealying the release. Signed-off-by: Israel Barth Rubio <[email protected]>
gonzalemario
force-pushed
the
rc-june-2024
branch
from
c7c1602
to
9efe476
Compare
barthisrael
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.