Add minimum EFM PgPool integration values #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment there is an option to enable EFM PgPool integration, but the integration is incomplete as it does not include the minimum parameters required by EFM to complete the integration. As such, the flag is currently not viable, even though it exists. This patch fixes this by making use of existing variables to populate the configuration when the flag is enabled, and allows for the attach and detach scripts to be made configurable.
Ianvdl
force-pushed
the
efm_pgpool_integration_patch
branch
from
55e06c4
to
b13620e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment there is an option to enable EFM PgPool integration, but the integration is incomplete as it does not include the minimum parameters required by EFM to complete the integration. As such, the flag is currently not viable, even though it exists.
This patch fixes this by making use of existing variables to populate the configuration when the flag is enabled, and allows for the attach and detach scripts to be made configurable.