-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated roles: init_dbserver, and setup_pgd #584
Conversation
…D, PGD CAMO, and PGD GROUP COMMIT SCOPES
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where are the commit scope files?
@@ -67,7 +67,7 @@ | |||
ansible.builtin.wait_for: | |||
port: "{{ pg_port }}" | |||
state: started | |||
msg: "Port {{ pg_port }} is listening." | |||
msg: "Port {{ pg_port }} is not listening." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this update for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be "Port {{ pg_port }} is listening."
, the msg is for when the task succeeds and completes
@@ -9,7 +9,7 @@ | |||
become: true | |||
when: | |||
- edb_master_key|length > 0 | |||
- pg_data not in edb_master_key_location | |||
- edb_master_key_location not in pg_data |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should also be pg_data not in edb_master_key_location
, the edb_master_key_location
is by default in {{ pg_data }}/keys
and so the pg_data
value would appear in the edb_master_key_location
variable, not the other way around.
@@ -1,7 +1,7 @@ | |||
--- | |||
- name: Verify edb_key_wrap_cmd and edb_key_unwrap_cmd | |||
- name: Verify edb_key_wrap_cmd is defined or not |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this should change it should read Verify edb_key_wrap_cmd and edb_key_unwrap_cmd are definded
roles/setup_pgd/README.md
Outdated
example for configuring two PGD commit scopes is listed below. | ||
|
||
The configuration requirements for PGD through the configuration setting variables are: | ||
1. Only one scope can be configured as default at a time. The variable to configure is: `default_group_cs` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update verify_tde_vars and README
ansible.builtin.fail: | ||
msg: "edb_key_wrap_cmd and edb_key_unwrap_cmd are must for initializing a cluster with TDE" | ||
msg: "edb_key_wrap_cmd and edb_key_unwrap_cmd are must for initializing a cluster" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should include something about with TDE
, these are not required for initializing a cluster, but are for initializing a cluster with TDE.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove blank lines
msg: "edb_key_wrap_cmd and edb_key_unwrap_cmd are must for initializing a cluster with TDE" | ||
msg: "edb_key_wrap_cmd and edb_key_unwrap_cmd are must for initializing a cluster" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as in init_dbserver
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Updated roles:
All tasks related to: