Add a cross account role to fetch S3 uploads #1319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdial89f
requested review from
Dark-Knight-1313,
kristin-at-theta,
bflynn-cms and
hannasage
as code owners
|
Endpoint URL - https://d1hhfhcvoh41d3.cloudfront.net |
Dark-Knight-1313
approved these changes
Aug 1, 2023
mdial89f
added a commit
that referenced
this pull request
Sep 12, 2023
* feat(cross-acct service): Create a cross acct role for uploads * correct names * deps * Add getobjecttagging perms so we can honor the clean tags
mdial89f
added a commit
that referenced
this pull request
Sep 12, 2023
* Add a source service to stream onemac data to kafka (#1292) * Add a source service to stream data out of dynamo * set the deploy to be conditional and honor the correct envs * Add a cross account role to fetch S3 uploads (#1319) * feat(cross-acct service): Create a cross acct role for uploads * correct names * deps * Add getobjecttagging perms so we can honor the clean tags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story: Part of https://qmacbis.atlassian.net/browse/OY2-24549
Endpoint: https://d1hhfhcvoh41d3.cloudfront.net/
Details
This changeset adds a new service (cross-acct) that creates a single IAM role. This role is trusted to be assumed by the platform acct, and will be used to fetch S3 uploads cross acct.
Changes
Implementation Notes
Test Plan
None.