CMDCT-4247 - v4 serverless upgrade #15041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
peoplespete
force-pushed
the
cmdct-4247
branch
from
d1b5789 to
4a516c1
Compare
peoplespete
force-pushed
the
cmdct-4247
branch
from
cd5ec66 to
3b257e7
Compare
peoplespete
force-pushed
the
cmdct-4247
branch
from
03e9040 to
fd2ebee
Compare
peoplespete
force-pushed
the
cmdct-4247
branch
from
fd2ebee to
d944ab6
Compare
peoplespete
force-pushed
the
cmdct-4247
branch
from
d944ab6 to
eb3e16d
Compare
peoplespete
force-pushed
the
cmdct-4247
branch
from
eb3e16d to
9444b17
Compare
peoplespete
force-pushed
the
cmdct-4247
branch
from
9444b17 to
cba6410
Compare
peoplespete
force-pushed
the
cmdct-4247
branch
from
cba6410 to
f6ae3fd
Compare
peoplespete
requested review from
BearHanded,
braxex,
jessabean and
benmartin-coforma
as code owners
JonHolman
reviewed
Jan 29, 2025
JonHolman
reviewed
Jan 29, 2025
peoplespete
force-pushed
the
cmdct-4247
branch
from
3ef7138 to
aaefe86
Compare
|
@benmartin-coforma @JonHolman Thanks for reviewing! I've made requested changes and it should be ready for a final looksee. 🙏 |
JonHolman
previously approved these changes
Jan 30, 2025
benmartin-coforma
requested changes
Jan 30, 2025
Co-authored-by: benmartin-coforma <[email protected]>
|
Code Climate has analyzed commit ca3f99e and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (90% is the threshold). This pull request will bring the total coverage in the repository to 82.5% (0.0% change). View more on Code Climate. |
1 task
benmartin-coforma
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade to Serverless V4
Related ticket(s)
CMDCT-4247
How to test
Notes
Pre-review checklist
Pre-merge checklist
Review
Security
If either of the following are true, notify the team's ISSO (Information System Security Officer).
convert to a different template: test → val | val → prod