Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the user/admin-create endpoint #15029

Merged
merged 4 commits into from
Jan 17, 2025
Merged

Remove the user/admin-create endpoint #15029

merged 4 commits into from
Jan 17, 2025

Conversation

benmartin-coforma
Copy link
Collaborator

Description

In theory, this allowed admins to create user profiles, primed and ready for the person to log in.

Cloudwatch shows this was actually done only a handful of times in 2021.

Additionally, imperfect sanitization of the username field could lead to CSV injection attacks, via the export on Users.jsx.

Therefore, we are removing the page altogether.

Related ticket(s)

CMDCT-4234


How to test

  1. Log in as an admin user
  2. Note that there is no link on the home page to "Create User"
  3. Go to the "View / Edit Users" page
  4. Note that there is no button above the table to "Add User"

Notes

n/a


Pre-review checklist

  • [ ] I have added thorough tests, if necessary
  • [ ] I have updated relevant documentation, if necessary
  • I have performed a self-review of my code
  • I have manually tested this PR in the deployed cloud environment

Pre-merge checklist

Review

  • Design: This work has been reviewed and approved by design, if necessary
  • Product: This work has been reviewed and approved by product owner, if necessary

Security

If either of the following are true, notify the team's ISSO (Information System Security Officer).

  • [ ] These changes are significant enough to require an update to the SIA.
  • These changes are significant enough to require a penetration test.

In theory, this allowed admins to create user profiles,
primed and ready for the person to log in.

Cloudwatch shows this was actually done only a handful of times in 2021.

Additionally, imperfect sanitization of the username field could
lead to CSV injection attacks, via the export on Users.jsx.
BearHanded
BearHanded previously approved these changes Jan 17, 2025
Copy link
Contributor

@BearHanded BearHanded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed the add button no longer exists

Copy link

codeclimate bot commented Jan 17, 2025

Code Climate has analyzed commit 900ad16 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 82.3% (0.2% change).

View more on Code Climate.

Copy link
Contributor

@ailZhou ailZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made a tiny little change to the styling as the padding on the edit user button is gone but everything else looks good!

@BearHanded BearHanded merged commit 5c799ac into master Jan 17, 2025
15 checks passed
@BearHanded BearHanded deleted the no-create-user branch January 17, 2025 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants