Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMDCT-4184 - sls side changes that can go out now #15028

Closed
wants to merge 12 commits into from

Conversation

peoplespete
Copy link
Contributor

Description

This is all of the SLS side changes that can go out now without harming our current setup.

Related ticket

CMDCT-4184


How to test

If you want to you can do the following to test this PR:
Poke around in the application that is built using sls

Notes

NA


Pre-review checklist

  • I have added thorough tests, if necessary
  • I have updated relevant documentation, if necessary
  • I have performed a self-review of my code
  • I have manually tested this PR in the deployed cloud environment

Pre-merge checklist

Review

  • Design: This work has been reviewed and approved by design, if necessary
  • Product: This work has been reviewed and approved by product owner, if necessary

Security

If either of the following are true, notify the team's ISSO (Information System Security Officer).

  • These changes are significant enough to require an update to the SIA.
  • These changes are significant enough to require a penetration test.

convert to a different template: test → val | val → prod

Copy link

codeclimate bot commented Jan 15, 2025

Code Climate has analyzed commit 78aa1b0 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 82.1% (0.0% change).

View more on Code Climate.

@peoplespete peoplespete marked this pull request as ready for review January 15, 2025 20:48
@peoplespete peoplespete deleted the cmdct-4184-sls-now branch January 15, 2025 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants