CMDCT-4238 - Prevent destroy from destroying serverless stacks unless particular resources are set to retain #15026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonHolman
requested review from
BearHanded,
braxex,
jessabean and
benmartin-coforma
as code owners
peoplespete
reviewed
Jan 14, 2025
peoplespete
reviewed
Jan 14, 2025
src/run.ts
Outdated
Comment on lines
221
to
246
| const resourcesToCheck = [ | ||
| { | ||
| templateKey: `database-${options.stage}`, | ||
| resourceKey: "FormAnswersTable", | ||
| }, | ||
| { | ||
| templateKey: `database-${options.stage}`, | ||
| resourceKey: "FormQuestionsTable", | ||
| }, | ||
| { | ||
| templateKey: `database-${options.stage}`, | ||
| resourceKey: "FormTemplatesTable", | ||
| }, | ||
| { templateKey: `database-${options.stage}`, resourceKey: "FormsTable" }, | ||
| { | ||
| templateKey: `database-${options.stage}`, | ||
| resourceKey: "StateFormsTable", | ||
| }, | ||
| { templateKey: `database-${options.stage}`, resourceKey: "StatesTable" }, | ||
| { templateKey: `database-${options.stage}`, resourceKey: "AuthUserTable" }, | ||
| { | ||
| templateKey: `ui-${options.stage}`, | ||
| resourceKey: "CloudFrontDistribution", | ||
| }, | ||
| { templateKey: `ui-auth-${options.stage}`, resourceKey: "CognitoUserPool" }, | ||
| ]; |
There was a problem hiding this comment.
You'd have to change some other code I'm sure but I wonder if you like this stripped down version of this same data:
const resourcesToCheck = {
`database-${options.stage}`: "FormAnswersTable",
`database-${options.stage}`: "FormQuestionsTable",
`database-${options.stage}`: "FormTemplatesTable",
`database-${options.stage}`: "FormsTable"
`database-${options.stage}`: "StateFormsTable",
`database-${options.stage}`,: "StatesTable"
`database-${options.stage}`: "AuthUserTable"
`ui-${options.stage}`: "CloudFrontDistribution",
`ui-auth-${options.stage}`: "CognitoUserPool"
}
peoplespete
reviewed
Jan 14, 2025
peoplespete
reviewed
Jan 14, 2025
src/run.ts
Outdated
| ); | ||
|
|
||
| if ( | ||
| ["master", "val", "production"].includes(options.stage) && |
There was a problem hiding this comment.
Any way to make this match isDev's definition? Also if that's complicated feel free to ignore.
There was a problem hiding this comment.
This isn't in the cdk branches, this will be in sls branches, so we don't have isDev.
peoplespete
previously approved these changes
Jan 14, 2025
Co-authored-by: Pete Dunlap <[email protected]>
|
Code Climate has analyzed commit 4df86bf and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (90% is the threshold). This pull request will bring the total coverage in the repository to 82.1% (0.0% change). View more on Code Climate. |
peoplespete
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Idea to avoid accidentally deleting important resources during the CDK migration
Related ticket(s)
CMDCT-4238
How to test
Notes
Pre-review checklist
Pre-merge checklist
Review
Security
If either of the following are true, notify the team's ISSO (Information System Security Officer).
convert to a different template: test → val | val → prod