CMDCT-4243 - serverless v4 upgrade #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peoplespete
force-pushed
the
cmdct-4243
branch
8 times, most recently
from
639a138 to
89e50e4
Compare
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
peoplespete
force-pushed
the
cmdct-4243
branch
from
89e50e4 to
ca71811
Compare
peoplespete
force-pushed
the
cmdct-4243
branch
from
e260641 to
9ce8b67
Compare
peoplespete
force-pushed
the
cmdct-4243
branch
from
9ce8b67 to
2211e55
Compare
JonHolman
reviewed
Jan 21, 2025
JonHolman
reviewed
Jan 21, 2025
JonHolman
reviewed
Jan 21, 2025
JonHolman
reviewed
Jan 21, 2025
JonHolman
previously approved these changes
Jan 21, 2025
peoplespete
force-pushed
the
cmdct-4243
branch
from
adc4769 to
691bca9
Compare
|
Code Climate has analyzed commit 691bca9 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (90% is the threshold). This pull request will bring the total coverage in the repository to 93.6% (0.0% change). View more on Code Climate. |
|
@JonHolman I think I addressed comments with either code changes or some explanation that I hope is sufficient :) |
JonHolman
reviewed
Jan 22, 2025
JonHolman
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now that QMR repo has shown the v4 serverless upgrade is not too too hard of a lift, we're doing it to all the repos.
Related ticket(s)
CMDCT-4243
How to test
Check out all the tests that ran (unit and playwright). You're also welcome to poke around in the app yourself:
https://d12xvfykgjoerg.cloudfront.net/
Important updates
NA
Author checklist
convert to a different template: test → val | val → prod