Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LTSS-3 Measure Overview Page #73

Merged
merged 2 commits into from
Dec 11, 2024
Merged

LTSS-3 Measure Overview Page #73

merged 2 commits into from
Dec 11, 2024

Conversation

rocio-desantiago
Copy link
Contributor

@rocio-desantiago rocio-desantiago commented Dec 9, 2024

Description

This PR adds the content for the LTSS-3 measure.
As of now, thanks to the all the great work done in setting up LTSS-1, I only had to update the qm.ts and cmit.ts files.

For this requirement:

I propose, holding off on the edit button going to a blank page at least until the routing by page id PR is merged in, so there's consistency with how we're routing.

  • Clicking the edit button should take you to that measure's delivery method page.

Notes from LTSS-1

  1. Children textboxes of the radio button currently does not save any data. Address in a separate PR.
  2. The quality measure table [Edit] buttons do not go anywhere yet. Address in a separate PR.

Related ticket(s)

CMDCT-4143


How to test

  1. Sign into HCBS, any state user
  2. Create a QM report
  3. On the sidebar menu, select [Optional Measure Results].
    • The 4th row down will be LTSS-3, CMIT # 963.
  4. Click [Edit] and you be taken to the LTSS-3 measure overview page.
  5. Check that the questions matches what is written in the jira ticket: CMDCT-4143 - same as LTSS-1
  6. You should see a page that looks like this
    LTSS-3

Important updates


Author checklist

  • I have performed a self-review of my code
  • I have added thorough tests, if necessary
  • I have updated relevant documentation, if necessary

@rocio-desantiago rocio-desantiago added the draft Just a draft label Dec 9, 2024
@rocio-desantiago rocio-desantiago changed the title initial setup of ltss-3 LTSS-3 Measure Overview Dec 9, 2024
Copy link

codeclimate bot commented Dec 9, 2024

Code Climate has analyzed commit ec2e9c6 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 94.6% (0.0% change).

View more on Code Climate.

@rocio-desantiago rocio-desantiago added ready for review Ready for all the reviews! and removed draft Just a draft labels Dec 9, 2024
@rocio-desantiago rocio-desantiago marked this pull request as ready for review December 9, 2024 21:32
@rocio-desantiago rocio-desantiago changed the title LTSS-3 Measure Overview LTSS-3 Measure Overview Page Dec 9, 2024
Copy link
Contributor

@benmartin-coforma benmartin-coforma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good!

Copy link
Contributor

@ajaitasaini ajaitasaini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally, looks good to me!

@rocio-desantiago rocio-desantiago merged commit 896b469 into main Dec 11, 2024
19 checks passed
@rocio-desantiago rocio-desantiago deleted the ltss-3 branch December 11, 2024 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Ready for all the reviews!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants