Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design Update: Replace PNG with SVG icons #26

Merged
merged 4 commits into from
Aug 28, 2024
Merged

Conversation

ailZhou
Copy link
Collaborator

@ailZhou ailZhou commented Aug 27, 2024

Description

A pr to swap all the images from .png to .svg before we start fully developing each page.

Related ticket(s)


How to test

Deploy Link: https://d2d4gtsz2lwisb.cloudfront.net/

  1. Sign into HCBS and make sure there's no dead images displayed

Important updates

N/A


Author checklist

  • I have performed a self-review of my code
  • I have added thorough tests, if necessary
  • I have updated relevant documentation, if necessary

convert to a different template: test → val | val → prod

Copy link
Contributor

@benmartin-coforma benmartin-coforma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SVGs rule, PNGs drool

@ailZhou ailZhou marked this pull request as ready for review August 27, 2024 20:50
Copy link

codeclimate bot commented Aug 28, 2024

Code Climate has analyzed commit 99b025e and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 80.8% (0.0% change).

View more on Code Climate.

@ailZhou ailZhou merged commit 58fe7c9 into main Aug 28, 2024
17 checks passed
@ailZhou ailZhou deleted the replace-icons-svg branch August 28, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants