Cmdct 3752 - Deploy UI services #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
BearHanded
requested review from
ajaitasaini,
angelaco11,
benmartin-coforma and
ailZhou
|
Code Climate has analyzed commit 8f588b8 and detected 2 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 90.1% (90% is the threshold). This pull request will bring the total coverage in the repository to 90.0%. View more on Code Climate. |
angelaco11
reviewed
Jul 8, 2024
ajaitasaini
approved these changes
Jul 8, 2024
angelaco11
approved these changes
Jul 8, 2024
| <head> | ||
| <meta charset="utf-8" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1" /> | ||
| <meta name="description" content="Medicaid Data Collection Tool" /> |
There was a problem hiding this comment.
should "description" match <title> here?
There was a problem hiding this comment.
I suppose these should be updated in the future with HCBS favicons
There was a problem hiding this comment.
Shall we delete this one?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deploy a login page without login functionality. This is just deploying the services for ui and ui-src, which will get us our cloudfront distributions. We can use those to get real URLs.
What cool stuff does this do?
Related ticket(s)
CMDCT-3752
How to test
https://d24wcdycbgw2lz.cloudfront.net/ <- This exists at all
Important updates
Author checklist
convert to a different template: test → val | val → prod