Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HCBS Header #14

Merged
merged 13 commits into from
Jul 31, 2024
Merged

HCBS Header #14

merged 13 commits into from
Jul 31, 2024

Conversation

rocio-desantiago
Copy link
Contributor

@rocio-desantiago rocio-desantiago commented Jul 26, 2024

Description

  • Header appears on Login
  • Logout Button is functional.
  • Updated icons for HCBS.

Related ticket(s)

CMDCT-3755


How to test

  1. Login as a stateuser
  2. Header should appear
    Screenshot 2024-07-26 at 5 27 04 PM
  3. Note: "Hello world" has been removed after some updates.
  4. After merging main, expect to see Header and Footer smooshed "for now"
    Screenshot 2024-07-30 at 3 37 15 PM

Author checklist

  • I have performed a self-review of my code
  • I have added thorough tests, if necessary
  • I have updated relevant documentation, if necessary

convert to a different template: test → val | val → prod

@rocio-desantiago
Copy link
Contributor Author

services/ui-src/src/components/menus/Menu.test.tsx can be improved

@rocio-desantiago rocio-desantiago marked this pull request as ready for review July 26, 2024 23:35
@ajaitasaini
Copy link
Contributor

this would be a good time to add the Header test file in!

Copy link
Contributor

@benmartin-coforma benmartin-coforma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I have some nitpicky comments below, but I'd also be fine merging this as-is.

services/ui-src/src/components/layout/Header.test.tsx Outdated Show resolved Hide resolved
services/ui-src/src/components/layout/Header.test.tsx Outdated Show resolved Hide resolved
services/ui-src/src/components/layout/Header.test.tsx Outdated Show resolved Hide resolved
services/ui-src/src/components/menus/Menu.test.tsx Outdated Show resolved Hide resolved
services/ui-src/src/components/menus/Menu.tsx Outdated Show resolved Hide resolved
Copy link

codeclimate bot commented Jul 30, 2024

Code Climate has analyzed commit 598922e and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 90.8% (0.5% change).

View more on Code Climate.

@rocio-desantiago rocio-desantiago merged commit b550eda into main Jul 31, 2024
17 checks passed
@rocio-desantiago rocio-desantiago deleted the hcbs-header-2 branch July 31, 2024 14:42
@rocio-desantiago rocio-desantiago removed the ready for review Ready for all the reviews! label Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants