Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HCBS Footer 1/x - Footer UI #11

Merged
merged 7 commits into from
Jul 30, 2024
Merged

HCBS Footer 1/x - Footer UI #11

merged 7 commits into from
Jul 30, 2024

Conversation

ajaitasaini
Copy link
Contributor

@ajaitasaini ajaitasaini commented Jul 24, 2024

Description

Related ticket(s)

CMDCT-3756


How to test

Log in and confirm you can see footer

NOTE: this PR only covers displaying the footer. Adding the routes in and re-organizing styles (if necessary) will be fast-follows to this PR

Important updates


Author checklist

  • I have performed a self-review of my code
  • I have added thorough tests, if necessary
  • I have updated relevant documentation, if necessary

convert to a different template: test → val | val → prod

@ajaitasaini ajaitasaini changed the title footer progress HCBS Footer Jul 29, 2024
@ajaitasaini ajaitasaini marked this pull request as ready for review July 29, 2024 13:53
@ajaitasaini ajaitasaini changed the title HCBS Footer HCBS Footer 1/x - Footer UI Jul 29, 2024
Copy link
Contributor

@rocio-desantiago rocio-desantiago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment. Merging both Header and Footer will be fun lol

Copy link

codeclimate bot commented Jul 30, 2024

Code Climate has analyzed commit 4ea9b43 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 90.2% (0.2% change).

View more on Code Climate.

@ajaitasaini ajaitasaini merged commit 5af6073 into main Jul 30, 2024
17 checks passed
@ajaitasaini ajaitasaini deleted the footer branch July 30, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants