[CMDCT-3817] Upgrade React-Router-Dom #139753
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 7b71347 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 89.2% (90% is the threshold). This pull request will bring the total coverage in the repository to 79.2% (-0.5% change). View more on Code Climate. |
gmrabian
requested changes
Aug 28, 2024
| @@ -39,7 +34,7 @@ const Timeout = () => { | |||
| unlisten(); | |||
| clearInterval(timer); | |||
| }; | |||
| }); | |||
| }, [location]); | |||
There was a problem hiding this comment.
the timeout isn't working as expected and I'm wondering if this might be why? it's listening on location and location won't change if you are not using the page
steps to reproduce:
- in
authLifecyclechange IDLE_WINDOW from 30 to 1 and PROMPT_AT from 29 to 0.5 - Log in and let sit until the modal pops up
- The modal displays and says you will be logged out in 59 seconds. The time never changes and it does not change the view after that time
| <Route path={"/state_assoc"} element={Unauthorized} /> | ||
| <Route path={"/role_jobcode_assoc"} element={Unauthorized} /> | ||
| <Route path={"/users"} element={Unauthorized} /> | ||
| </Routes> |
There was a problem hiding this comment.
Just a thought in reviewing these: is it normal to control routes by user type? or to have all routes and restrict them on a component level by type? just curious
| @@ -107,7 +107,7 @@ export const Header = () => { | |||
| <li> | |||
| <a | |||
| data-testid={"headerDropDownMenuButton"} | |||
| href="#menu" | |||
| href="javascript:void(0);" | |||
ntsummers1
added
in progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The long awaited react-router upgrade is here, and the fruits of our labor can finally be fully observed. Bask in the hooks that make this a lot easier to use router!
Related ticket(s)
CMDCT-3817
How to test
Log in as a stateuser
Enter a report
Navigate through the sections, clicking any buttons you see to go to different pages. I.E., check the Sidebar, the print actions button on the bottom, the navigation buttons on the bottom, etc.
If everything loads, fill in some data and make sure it saves
Use the top right menu to check that your state user info shows up in the account page
Click the banner image to see you navigate to the root page
Sign out
Sign in as an admin
Repeat the same steps as above and it should all work
Notes
React-Router is removed
React-Router-Dom 5.2 -> 6.26
Pre-review checklist
Pre-merge checklist
Review