-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(notifications): add notification api and update banner #986
Open
daniel-belcher
wants to merge
13
commits into
main
Choose a base branch
from
notif-api
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-belcher
had a problem deploying
to
notif-api
January 8, 2025 15:26 — with
GitHub Actions
Failure
daniel-belcher
temporarily deployed
to
notif-api
January 8, 2025 15:26 — with
GitHub Actions
Inactive
Coverage Report
File Coverage
|
daniel-belcher
temporarily deployed
to
notif-api
January 8, 2025 15:30 — with
GitHub Actions
Inactive
daniel-belcher
temporarily deployed
to
notif-api
January 8, 2025 15:30 — with
GitHub Actions
Inactive
daniel-belcher
temporarily deployed
to
notif-api-kibana
January 8, 2025 15:31 — with
GitHub Actions
Inactive
daniel-belcher
temporarily deployed
to
notif-api-app
January 8, 2025 15:31 — with
GitHub Actions
Inactive
daniel-belcher
temporarily deployed
to
notif-api
January 8, 2025 15:31 — with
GitHub Actions
Inactive
daniel-belcher
temporarily deployed
to
notif-api
January 8, 2025 15:39 — with
GitHub Actions
Inactive
daniel-belcher
had a problem deploying
to
notif-api
January 8, 2025 15:39 — with
GitHub Actions
Failure
daniel-belcher
temporarily deployed
to
notif-api
January 8, 2025 15:43 — with
GitHub Actions
Inactive
daniel-belcher
temporarily deployed
to
notif-api
January 8, 2025 15:43 — with
GitHub Actions
Inactive
daniel-belcher
temporarily deployed
to
notif-api-app
January 8, 2025 15:43 — with
GitHub Actions
Inactive
daniel-belcher
temporarily deployed
to
notif-api-kibana
January 8, 2025 15:43 — with
GitHub Actions
Inactive
daniel-belcher
temporarily deployed
to
notif-api
January 8, 2025 15:43 — with
GitHub Actions
Inactive
jdinh8124
approved these changes
Jan 8, 2025
asharonbaltazar
approved these changes
Jan 9, 2025
Comment on lines
+7
to
+8
const { dismissed, clearNotif } = useNotifs(); | ||
const result = useGetSystemNotifs(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we consolidate these two hooks? Will they ever be used independently?
If yes, we can definitely move all this logic into the hook and let the component just concern itself with presentation
daniel-belcher
had a problem deploying
to
notif-api
January 14, 2025 15:46 — with
GitHub Actions
Failure
daniel-belcher
temporarily deployed
to
notif-api
January 14, 2025 15:46 — with
GitHub Actions
Inactive
daniel-belcher
temporarily deployed
to
notif-api
January 14, 2025 15:50 — with
GitHub Actions
Inactive
daniel-belcher
temporarily deployed
to
notif-api
January 14, 2025 15:50 — with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add parameter for notifications to be added as needed. Update Banner to use this system. Store dismissed locally.
🎫 Linked Ticket
ticket to close
related ticket
💬 Description / Notes
Initial dive into ticket was focused on database for dismissed notifications, as well as a more detailed table for notifications. This was deemed unnecessary and ticket was redone using a simple parameter for notification storage and to switch dismissed notifications to local storage so as not to have a table with User info.
🛠 Changes