feat(four fields): This change add required fields to the submission forms #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9f6889f.
mdial89f
approved these changes
Mar 11, 2024
| SPA_TYPE_NAME: type.SPA_TYPE_NAME.replace(/â|â/g, "-"), | ||
| }; | ||
| }) || null, | ||
| subTypes: |
| @@ -3,10 +3,8 @@ | |||
| "version": "0.0.0", | |||
| "dependencies": { | |||
| "@aws-sdk/client-cognito-identity-provider": "^3.350.0", | |||
| "@aws-sdk/client-dynamodb": "^3.281.0", | |||
| @@ -87,6 +87,7 @@ describe("getNextBusinessDayTimestamp", () => { | |||
| expect(nextDate).toEqual(Date.UTC(2024, 0, 16)); // Tuesday, midnight utc | |||
| }); | |||
|
|
|||
| // TODO: I dont know if its my time zone but this always fails for me in the MST | |||
There was a problem hiding this comment.
The test date is created for 3pm local, not explicitly eastern. So, 3pm local for you is 5pm east coast. The logic for getNextBizDay includes "if 5pm or after, go to the next day". 3pm your time is exactly 5pm, and should return the next day. Test isn't accounting for being run in other timezones. Wouldn't hold up merge to fix anything, in addition some of this might be changing or have changed with the unit test effort.
| { | ||
| match_phrase: { | ||
| name: { | ||
| query: "Do Not Use", |
| maximumRetryAttempts: 0 | ||
| environment: | ||
| region: ${self:provider.region} | ||
| osDomain: ${param:osDomain} | ||
| events: | ||
| - http: | ||
| path: /getSeaTypes | ||
| path: /getTypes |
hannasage
approved these changes
Mar 11, 2024
mdial89f
approved these changes
Mar 14, 2024
|
🎉 This PR is included in version 1.5.0-val.15 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issues to Close
(for the epic)
https://qmacbis.atlassian.net/browse/OY2-27187
test link: https://d3tv3xhp6q8ov4.cloudfront.net/
Description of Changes
subject,description,types, andsubtypesin SPA WAIVER and Medicaid form submission pages, as per Figma design guidelines.typeandsubtypefields to support multiple selections, enabling users to specify more than one option as applicable.typetoauthoritywhere relevant to better reflect its purpose.DetailSidebarcomponent that dynamically displays relevant sidebar items on the details page, based on the existing data.submission/commondirectory to standardize the UI and facilitate reuse.Impact of Changes
These changes introduce new data collection fields in the form submission process, which may require users to adapt to the updated submission requirements. The database schema and related APIs have been updated to accommodate the new data types and structures. No backward-incompatible changes are introduced, but users should review the updated submission process for SPA WAIVER and Medicaid forms.
Additional Notes
*** We are still waiting on final approval form the business for the changes to the ui**