refactor(app-router): finish overhaul of routing #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannasage
suggested changes
Jan 19, 2024
hannasage
reviewed
Jan 19, 2024
src/services/ui/src/pages/create/external-landing/ExternalAppLandingPage.tsx
Outdated
Show resolved
Hide resolved
hannasage
approved these changes
Jan 19, 2024
pkim-gswell
changed the title
pkim-gswell
added
the
type: REFACTOR
|
🎉 This PR is included in version 1.5.0-val.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
There were still a few missed pieces with the routing that needed be changed. This is in reference to the work that @pkim-gswell did with the router.
Approach
The goal here was to change to using typesafe strings wherever I saw enums.