Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(abp 10): create abp 10 General assurances webform #333

Merged
merged 34 commits into from
Jan 19, 2024
Merged

Conversation

jdinh8124
Copy link
Collaborator

@jdinh8124 jdinh8124 commented Jan 18, 2024

Purpose

Created ABP 10 webform, there is some logic to show a specific input only when a select element's value is "no". Selects currently don't have slots in their options components. Instead the input was create as a slot sibling with dependency and styling logic.

Screen Shot 2024-01-18 at 1 40 01 PM

Linked Issues to Close

https://qmacbis.atlassian.net/browse/OY2-27073

@jdinh8124 jdinh8124 marked this pull request as ready for review January 18, 2024 21:44
Copy link
Collaborator

@daniel-belcher daniel-belcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependency looks solid, a clean form done.

Copy link
Contributor

@pkim-gswell pkim-gswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iapprove

@jdinh8124 jdinh8124 merged commit 8987056 into master Jan 19, 2024
16 checks passed
@pkim-gswell pkim-gswell added the type: FEAT Submit new features label Jan 24, 2024
Copy link
Contributor

🎉 This PR is included in version 1.5.0-val.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants