feat(OY2-26082): Package actions FE #317
Conversation
| type Attachments = NonNullable<opensearch.changelog.Document["attachments"]>; | ||
|
|
||
| export const useAttachmentService = ( | ||
| props: Pick<opensearch.changelog.Document, "packageId"> |
There was a problem hiding this comment.
There is some redundancy between the prop and the function signatures within the hook.
The main reason this requires the top level changelog document is for access to the packageId. In addition, it provided consistent props scaffolding.
| const [loading, setLoading] = useState(false); | ||
| const [error, setError] = useState(""); | ||
|
|
||
| const onUrl = async (ATT: Attachments[number]) => { | ||
| setLoading(true); | ||
| try { | ||
| return await getAttachmentUrl( | ||
| props.packageId, | ||
| ATT.bucket, | ||
| ATT.key, | ||
| ATT.filename | ||
| ); | ||
| } catch (e) { | ||
| const err = e instanceof Error ? e.message : "Failed download"; | ||
| setError(err); | ||
| } finally { | ||
| setLoading(false); | ||
| } | ||
| }; |
There was a problem hiding this comment.
Can we utilize react-query for this, and pass the export thru this hook?
There was a problem hiding this comment.
I completely overlooked that... great point out!
Makes it much cleaner 🤟
Official guidance is to remove the GMT -X bit. |
There was a problem hiding this comment.
@pkim-gswell It looks like the fixes are in, and this all looks great.
|
🎉 This PR is included in version 1.5.0-val.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Purpose
This ticket is part of the FE piece to the Package Activity + Admin Package changelog epic.
The initial Package Activity and Admin Package section views were started in the previous ticket.
Included in this PR are the multi-attachment "download all" functionality.
Linked Issues to Close
https://qmacbis.atlassian.net/browse/OY2-26082
Approach
In the initial planning phase, I identified two possible solution paths for download all.
getAttachmentsendpoint and installing external dependencies to enable the FE for zipping.I went with the latter approach. With our existing systems, FE dedicated responsibility was more practical and required less additional code.
new dependencies added:
Assorted Notes/Considerations/Learning
List any other information that you think is important... a post-merge activity, someone to notify, what you learned, etc.