Padma t1 #202
Merged
Padma t1 #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-belcher
requested review from
benjaminpaige,
jdinh8124 and
charmcitygavin
jdinh8124
approved these changes
Nov 17, 2023
| extends React.TextareaHTMLAttributes<HTMLTextAreaElement> {} | ||
| extends React.TextareaHTMLAttributes<HTMLTextAreaElement> { | ||
| charcount?: "simple" | "limited"; | ||
| charcountstyling?: string; |
There was a problem hiding this comment.
Could this be:
charcountStyling?
There was a problem hiding this comment.
Where it's being applied it causes a loud warning about needing to be lowercase for custom DOM attributes.
There's probably a better way to add these two properties in general.
benjaminpaige
approved these changes
Nov 17, 2023
Comment on lines
+89
to
+98
| const opts = useMemo(() => { | ||
| if (hops.sort) { | ||
| const sorted = hops.options.sort((a, b) => | ||
| a.label.localeCompare(b.label) | ||
| ); | ||
| hops.sort === "descending" && sorted.reverse(); | ||
| return sorted; | ||
| } | ||
| return hops.options; | ||
| }, [hops.options, hops.sort]); |
|
🎉 This PR is included in version 1.5.0-val.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Round one of Padma testing concerns.