Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(package-actions): Enable/Disable Formal RAI Response Withdraw #192

Merged
merged 20 commits into from
Nov 15, 2023
Merged

feat(package-actions): Enable/Disable Formal RAI Response Withdraw #192

merged 20 commits into from
Nov 15, 2023

Conversation

hannasage
Copy link

@hannasage hannasage commented Nov 9, 2023 •
edited
Loading

Purpose

This PR adds the ToggleRAIResponseWithdraw pseudo-form (it's static, no inputs) and API to enable or disable the RAI Response Withdraw functionality

Linked Issues to Close

https://qmacbis.atlassian.net/browse/OY2-25560
https://qmacbis.atlassian.net/browse/OY2-25765

Approach

Plugged in the new component to the Actions index component, and it switches verbiage based on the :type param in the path. Going to /action/enable-rai-withdraw results in Enable language, and /action/disable-rai-withdraw results in Disable language. The endpoint switches on this same value.

The backend route is /action/{actionType} and switches on the Action enum just like the front-end routing. Each function is self-contained to keep the switch clean. We toggle the boolean value of raiWithdrawEnabled based on the given action (enable vs disable).

Assorted Notes/Considerations/Learning

N/A

@hannasage hannasage self-assigned this Nov 9, 2023
@hannasage hannasage marked this pull request as ready for review November 9, 2023 16:20
Kevin Haube and others added 4 commits November 9, 2023 13:20
Refactor general error handling into component
7b06993
UX bug fix: debounce auto nav to allow data to change and correct act…
5549f33 
…ions to display
@13bfrancis
Squashed commit of the following:
0b76490 
commit 7563b25
Author: 13bfrancis <[email protected]>
Date:   Thu Nov 9 12:29:20 2023 -0500

    fix build error

commit e3c2c18
Author: 13bfrancis <[email protected]>
Date:   Thu Nov 9 12:12:41 2023 -0500

    fix errors with sink

commit 50e4f86
Author: 13bfrancis <[email protected]>
Date:   Wed Nov 8 15:43:36 2023 -0500

    fix index -1 error

commit d489faa
Author: 13bfrancis <[email protected]>
Date:   Wed Nov 8 15:10:45 2023 -0500

    fix errors and lets reindex

commit 9976017
Author: 13bfrancis <[email protected]>
Date:   Wed Nov 8 11:03:24 2023 -0500

    fix typescript error for tombstone

commit 2f6e865
Author: 13bfrancis <[email protected]>
Date:   Wed Nov 8 09:53:04 2023 -0500

    finished up flow (fingers crossed)

commit 0afb047
Author: 13bfrancis <[email protected]>
Date:   Wed Nov 8 09:09:52 2023 -0500

    fix breadcrumb type error

commit 053441f
Author: 13bfrancis <[email protected]>
Date:   Wed Nov 8 09:06:13 2023 -0500

    remove action-type from schema (not needed)

commit 00eff86
Author: 13bfrancis <[email protected]>
Date:   Wed Nov 8 09:04:18 2023 -0500

    add functionality for sinking actions to opensearch

commit 43eaf99
Author: Mike Dial <[email protected]>
Date:   Tue Nov 7 14:47:25 2023 -0500

    bringing in brian

commit d8c4af4
Author: Mike Dial <[email protected]>
Date:   Tue Nov 7 14:27:13 2023 -0500

    fix thing

commit b4bbbeb
Author: Mike Dial <[email protected]>
Date:   Tue Nov 7 14:19:37 2023 -0500

    brians lib

commit 8b520a5
Author: Mike Dial <[email protected]>
Date:   Tue Nov 7 14:15:19 2023 -0500

    yut

commit 1a92952
Merge: c045e36 35b4780
Author: Mike Dial <[email protected]>
Date:   Tue Nov 7 13:42:17 2023 -0500

    Merge branch 'master' into issuerai

commit c045e36
Author: Mike Dial <[email protected]>
Date:   Tue Nov 7 13:41:20 2023 -0500

    sink

commit f2d7ab6
Author: Mike Dial <[email protected]>
Date:   Tue Nov 7 09:38:56 2023 -0500

    basic func

commit e164a3e
Author: Mike Dial <[email protected]>
Date:   Tue Nov 7 06:51:17 2023 -0500

    nothing

commit 9970b9c
Author: Mike Dial <[email protected]>
Date:   Tue Nov 7 06:48:08 2023 -0500

    form work

commit 9943c17
Author: Mike Dial <[email protected]>
Date:   Tue Nov 7 06:02:30 2023 -0500

    base

commit 76081ac
Author: Mike Dial <[email protected]>
Date:   Tue Nov 7 05:40:31 2023 -0500

    basic routing setup

commit 5917321
Author: Mike Dial <[email protected]>
Date:   Tue Nov 7 05:35:31 2023 -0500

    Show issue rai for all records for cms user
@13bfrancis
fix type error
c2b9840
@hannasage hannasage changed the title feat(package-actions): Enable/Disable RAI Response front-end setup feat(package-actions): Enable/Disable Formal RAI Response Nov 15, 2023
@hannasage hannasage changed the title feat(package-actions): Enable/Disable Formal RAI Response feat(package-actions): Enable/Disable Formal RAI Response Withdraw Nov 15, 2023
benjaminpaige
benjaminpaige approved these changes Nov 15, 2023
View reviewed changes
Copy link
Collaborator

@benjaminpaige benjaminpaige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple comments, but nothing that would stop you from merging

src/packages/shared-types/seatool.ts
@@ -144,7 +144,7 @@ export const transformSeatoolData = (id: string) => {
const { leadAnalystName, leadAnalystOfficerId } = getLeadAnalyst(data);
const { raiReceivedDate, raiRequestedDate } = getRaiDate(data);
const { stateStatus, cmsStatus } = getStatus(
data.SPW_STATUS?.[0].SPW_STATUS_DESC
data.SPW_STATUS?.at(-1)?.SPW_STATUS_DESC
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as long as these are always in order i guess

src/services/api/handlers/packageActions.ts
Comment on lines +39 to +49
export async function withdrawRai(id, timestamp) {
console.log("CMS withdrawing an RAI");
}

export async function respondToRai(id, timestamp) {
console.log("State respnding to RAI");
}

export async function withdrawPackage(id, timestamp) {
console.log("State withdrawing a package.");
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming these are just placeholders

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think Mike put those there

src/services/ui/src/pages/actions/IssueRai.tsx
</I.Button>
<Modal
showModal={successModalIsOpen}
// eslint-disable-next-line react/no-children-prop
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we not just use children?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idk why mike chose what he chose, but we need to unify every action form to use one user experience pattern so this will be remediated soon.

src/services/ui/src/pages/actions/IssueRai.tsx
Comment on lines +198 to +213
<p>
An error occurred during issue.
<br />
You may close this window and try again, however, this likely requires
support.
<br />
<br />
Please contact the{" "}
<a
href="mailto:[email protected]"
className="text-blue-500"
>
helpdesk
</a>{" "}
. You may include the following in your support request: <br />
<br />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks like a dial job here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

90% of life is just showing up

@hannasage hannasage merged commit ee8d599 into master Nov 15, 2023
15 checks passed
@hannasage hannasage deleted the oy2-25560-form branch November 15, 2023 18:41
@github-actions GitHub Actions
Copy link
Contributor

🎉 This PR is included in version 1.5.0-val.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@13bfrancis 13bfrancis 13bfrancis approved these changes

@benjaminpaige benjaminpaige benjaminpaige approved these changes

@mdial89f mdial89f Awaiting requested review from mdial89f

@Walesango2 Walesango2 Awaiting requested review from Walesango2

Assignees

@hannasage hannasage

Labels
released on @val
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hannasage @benjaminpaige @13bfrancis @mdial89f