Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Role based users update): update package status in all instances where applicable #187

Merged
merged 6 commits into from
Nov 13, 2023

Conversation

Walesango2
Copy link
Contributor

Purpose

The purse of this change is to make sure that when help desk user login to mako they are only able to see submissions that are under review. there was also a need to replace the idm url with the test url

Linked Issues to Close

https://qmacbis.atlassian.net/browse/OY2-25702

Approach

What was done her was to make sure that all instances where status of the submission is display was updated to reflect the change. Changes was made to the filter, the dashboard column nm the package header

@Walesango2 Walesango2 requested a review from hannasage November 8, 2023 15:18
Copy link
Collaborator

@13bfrancis 13bfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good. Just a couple console.log statements that need removed.

export const useOsAggregate = () => {
const { data: user } = useGetUser();
const { state } = useOsParams();
const aggs = useQuery({
refetchOnWindowFocus: false,
queryKey: [state.tab],
queryFn: (props) => {
console.log(user);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove this console.log

@@ -73,6 +71,11 @@ const PackageActionsCard = ({ id }: { id: string }) => {
export const DetailsContent = ({ data }: { data?: ItemResult }) => {
const { data: user } = useGetUser();
if (!data?._source) return <LoadingSpinner />;
console.log(data._source);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove this

@Walesango2 Walesango2 merged commit 3a9d290 into master Nov 13, 2023
15 checks passed
@Walesango2 Walesango2 deleted the status branch November 13, 2023 14:13
Copy link
Contributor

🎉 This PR is included in version 1.5.0-val.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants