-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Role based users update): update package status in all instances where applicable #187
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good. Just a couple console.log statements that need removed.
export const useOsAggregate = () => { | ||
const { data: user } = useGetUser(); | ||
const { state } = useOsParams(); | ||
const aggs = useQuery({ | ||
refetchOnWindowFocus: false, | ||
queryKey: [state.tab], | ||
queryFn: (props) => { | ||
console.log(user); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove this console.log
@@ -73,6 +71,11 @@ const PackageActionsCard = ({ id }: { id: string }) => { | |||
export const DetailsContent = ({ data }: { data?: ItemResult }) => { | |||
const { data: user } = useGetUser(); | |||
if (!data?._source) return <LoadingSpinner />; | |||
console.log(data._source); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove this
🎉 This PR is included in version 1.5.0-val.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Purpose
The purse of this change is to make sure that when help desk user login to mako they are only able to see submissions that are under review. there was also a need to replace the idm url with the test url
Linked Issues to Close
https://qmacbis.atlassian.net/browse/OY2-25702
Approach
What was done her was to make sure that all instances where status of the submission is display was updated to reflect the change. Changes was made to the filter, the dashboard column nm the package header