Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(UI): Add query/hook for forms API to UI #183

Merged
merged 17 commits into from
Nov 2, 2023
Merged

Conversation

charmcitygavin
Copy link
Collaborator

Purpose

This allows the UI to receive form data from the API

Linked Issues to Close

https://qmacbis.atlassian.net/browse/OY2-25508

Approach

It adds a useGetForm method that submits a form ID and form version and receives a JSON object for the requested form.

Assorted Notes/Considerations/Learning

We wrapped the returned data in the response wrapper to handle CORS issues, etc.

Copy link
Collaborator

@benjaminpaige benjaminpaige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one small change please

src/services/ui/src/api/useGetForm.ts Outdated Show resolved Hide resolved
src/services/ui/src/api/useGetForm.ts Show resolved Hide resolved
Copy link
Collaborator

@jdinh8124 jdinh8124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things are coming together its awesome to see

@charmcitygavin charmcitygavin merged commit c4d516b into webforms Nov 2, 2023
Copy link
Contributor

🎉 This PR is included in version 1.5.0-val.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants