feat(package actions): Set up API to return actions; UI to read and render actions #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannasage
requested review from
benjaminpaige,
13bfrancis,
mdial89f and
Walesango2
added 12 commits
November 2, 2023 10:04
Comment on lines
39
to
40
| found: boolean; | ||
| actions: Action[]; |
There was a problem hiding this comment.
i dont think we are including these now right?
Comment on lines
52
to
60
| {data.actions.map((action, idx) => ( | ||
| <Link | ||
| className="text-sky-500 underline" | ||
| to={`/action/${id}/${action}`} | ||
| key={`${idx}-${action}`} | ||
| > | ||
| <li>{mapActionLabel(action)}</li> | ||
| </Link> | ||
| ))} |
There was a problem hiding this comment.
should we show some default text if no actions are available?
There was a problem hiding this comment.
Added in ternary to render default text when no length is present in the array 👍🏼
benjaminpaige
approved these changes
Nov 2, 2023
|
🎉 This PR is included in version 1.5.0-val.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR handles preliminary work necessary for all package actions tickets forthcoming. It enables developers to create the conditions in which a package action is to be added to the API response for an item, and render out the option on the Details page of the UI.
Linked Issues to Close
Does not close any issues.
Approach
Package actions are not something that come through the sink in either data model (SEA Tool or OneMAC), so we have to infer package actions available based on the data within a package and a user's authorization to perform each action. There is precedent for this in OneMAC here.
We've implemented a similar approach in this PR with one exception: we have a designated endpoint
getPackageActionsfor this. We don't pack them into theitemresponse.Form Routing
The action strings given from the API will map to a dynamic URL (i.e.
/action/:type). To make use of React Router's dynamic segments, we have a single ActionFormIndex. We use that:typesegment to return the proper UI from this component.Dynamic segments are enumerated in the
Actionenum inshared-typesAssorted Notes/Considerations/Learning
Set up a new action:
packageActionsForResultfunctionmapActionLabelfunctionActionFormIndex