Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): hide errors for individual files when uploading subsequent docs #1055

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

asharonbaltazar
Copy link
Collaborator

@asharonbaltazar asharonbaltazar commented Jan 23, 2025

🎫 Linked Ticket

OY2-32247

💬 Description / Notes

We needed to overwrite the previous schema with an optional value to hide the schema's attachments property's respective errors. This also meant the files property needed an update allowing us to access those properties in a type-safe way.

🛠 Changes

  • some fancy zod manipulation

📸 Screenshots / Demo

Screen.Recording.2025-01-22.at.8.04.22.PM.mov

@asharonbaltazar asharonbaltazar changed the title fix: hide errors pertaining to individual files when upload subsequen… fix(ui): hide errors for individual files when uploading subsequent docs Jan 23, 2025
Copy link
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 80.14% 3747 / 4675
🔵 Statements 79.45% 4075 / 5129
🔵 Functions 70.25% 1084 / 1543
🔵 Branches 61.58% 1699 / 2759
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
react-app/src/components/ActionForm/index.tsx 94.59% 85.29% 87.5% 94.44% 275-276
react-app/src/features/forms/post-submission/upload-subsequent-documents/index.tsx 74.28% 57.14% 88.88% 74.28% 22, 69, 77-88, 151
Generated in workflow #1618 for commit ba09ecb by the Vitest Coverage Report Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant