-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): No longer trigger the <TimeoutModal> on "public" pages #1052
base: main
Are you sure you want to change the base?
Conversation
Coverage Report
File Coverage
|
); | ||
}; | ||
|
||
const publicRoutes = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@13bfrancis Can you review the public and private routes to make sure I got them right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked through and these routes look accurate :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you just need to fix some tests. Do that and I can re-review and approve your PR
); | ||
}; | ||
|
||
const publicRoutes = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked through and these routes look accurate :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from the test error, looks great 👍
🎫 Linked Ticket
OY2-31419
💬 Description / Notes
Updates routes to utilize a "Public" and "Private" pattern. Even though private routes aren't actually enforcing authentication they will log out a user after a period of time. I put a comment in the code to reflect this:
🛠 Changes
<TimeoutModal>
fromsrc/main.tsx
tosrc/router.tsx
and only included the<TimeoutModal>
for routes that are behind authentication.