Skip to content

Commit

Permalink
fix(OS-filters): add adjustments for filters from Padma's feedback
Browse files Browse the repository at this point in the history
* remove logs

* Resolve font size and spacing issues

* Add border and top gradient to form

* Add top padding after adding border/gradient

* feat(webform): doc initializer

* feat(webform): doc initializer

* feat(webform): doc initializer

* add the rest of abp 1 data

* minor name tweaks

* add scroll for select to account for quantity

* Create useGetForm

* Test useGetForm

* Export useGetForm

* add accessibility issues

* Temporarily disable authorizer

* Temporarily hard-code formId

* Wrap returns in response

* Temp. disable 400 response

* Update index.tsx

* Update index.tsx

* Re-enable error 400 response

* Update index.tsx

* Update index.tsx

* WIP: Receive params instead of a body for GET req

* WIP: Use query params

* Cleanup

* Cleanup

* Reenable AWS IAM roles for forms endpoint

* Use formID variable as query key

* Add a TODO reminder to use the Document type

* continue to run accessibilities

* feat(webform): doc validator

* feat(webform): doc validator

* fix(OY-25433): WIP filter changes

* Fix routing issue

* add type

* working through date logic

* Update FilterableDateRange.tsx

* Ensure text size is consistent across form and with Figma

* Labels should not be bold by default according to designs

* Adjust leading to better reflect design

* Adjust form title spacing to match design

* Update ABP1 copy to match Figma

* add route back to temp form

* push calendar logic

* feat(misc-inputs): Handle non standard numerical inputs

* little cleanup

* updated ui logic

* adjust date clearing logic

* add unregister effect in Slot comp

* Add required attribute to abp1

* fix: change switch to radio with children

* fix accessibility and race condition

* add end of day logic

* fix: change to singular checkbox with child

* fix: remove fieldArray-fieldGroup undefined error

* fix: remove default Select and Radio options

* fix: select auto-sized for values

* Update FilterableDateRange.tsx

* Update FilterableDateRange.tsx

* fix: fields no longer sharing names

* fix: account for sub-group groups

* fix test

* fix end of day logic in range

* first pass through Padma feedback

* text changes

* clean logic

* fix: name mismatch

* add char limit to fields and text changes

* text changes

* trying new logic with new object

* add get logic

* types

* adjust types

* adjust types

* Update index.tsx

* type check

* Update initializer.ts

* Update index.tsx

* Update index.tsx

* Add a Register button for logged-out users

* fix: switch now changing values in form

* Add webforms page and conditional header link

* feat: add select sorting

* testing logic

* Update forms.ts

* fix logic

* running type logic

* Update forms.ts

* adjust build

* add build logic

* Update serverless.yml

* Update serverless.yml

* Update tsconfig.json

* Update package.json

* Update tsconfig.json

* Set up basic route for user profile

* Add Profile route to ROUTES

* add logic

* Update forms.ts

* Update forms.ts

* nodenext

* log

* Update package.json

* adjust logic

* Update serverless.yml

* Update serverless.yml

* Update serverless.yml

* Update serverless.yml

* Update serverless.yml

* fix(char-limit): remove character limit in abp1

* Update serverless.yml

* Update serverless.yml

* Update serverless.yml

* change file

* Update forms.ts

* .js

* Update forms.ts

* next

* Update forms.ts

* Update serverless.yml

* itteratting

* itteratting

* Update v1.ts

* Update tsconfig.json

* Update package.json

* Update forms.ts

* Update forms.ts

* json

* Update package.json

* Update tsconfig.json

* adding logic

* cleanup

* Clean up logic

* update webforms link check

* Move form into Webform component dir

* Improve spacing

* Remove Access box for now

* Add alert banner

* add save draft

* Move form schema types to shared folder

* Cleanup

* run logic

* Additional cleanup

* Update index.tsx

* pra disclosure

* Update package.json

* Add isAuth to webform link condition

* adjust logic with new webforms pull

* Updated label per design feedback

* Set up structure for dropdown menu

* Add links to dropdown

* Update menu colors and layout

* Add an arrow to indicate dropdown menu

* add data check

* Improve layout to better match design

* Parmaeterize the url to idm

* removed nulls

* bump

* guarentee formschema

* Add a nicer default

* add logic in case of no data

* rename footer and temp remove back button

* footer rename and relocation

* Use self-closing tag

* Remove cruft

* Parameterize idm url

* one more

* Remove unused consts

* Add parameterized IDM link

* Move rolesDescriptions to user.ts

* Improve My Account menu styling

* Store role descriptions as object and remove function

* Get role description strings from shared types

* Simplify type

* Update src/services/ui/src/components/Layout/index.tsx

Co-authored-by: Benjamin Paige <[email protected]>

* Improve a11y

* Restore top level H1

* coonvert form regex for json transmission

* small fix

* var name change

* Prettier

* add new diagram

* smaller svg

* adjust a thing

* css changes

* Update useOpensearch.ts

* cleanup

* add git ignore

* Update .gitignore

* Update consts.ts

---------

Co-authored-by: Daniel Belcher <[email protected]>
Co-authored-by: Benjamin Paige <[email protected]>
Co-authored-by: Gavin St. Ours <[email protected]>
Co-authored-by: Paul Kim <[email protected]>
Co-authored-by: Paul Kim <[email protected]>
Co-authored-by: Daniel Belcher <[email protected]>
Co-authored-by: Mike Dial <[email protected]>
  • Loading branch information
8 people authored Dec 8, 2023
1 parent e628e2d commit 6f41456
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 6 deletions.
2 changes: 2 additions & 0 deletions src/services/api/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
# git ignore js files built by schema versions
/layers/**/*.js
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,12 @@ export function FilterableDateRange({ value, onChange, ...props }: Props) {
{label}
</div>
</PopoverTrigger>
<PopoverContent className="w-auto p-0" align="start">
<PopoverContent
className="w-auto p-0"
align="start"
side="left"
sideOffset={1}
>
<Calendar
disabled={[{ after: new Date() }]}
initialFocus
Expand Down
8 changes: 4 additions & 4 deletions src/services/ui/src/components/Opensearch/Filtering/consts.ts
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ const SPA_FILTER_GROUP = (isCms: boolean): FilterGroup => {
value: { gte: undefined, lte: undefined },
},
"leadAnalystName.keyword": {
label: "CPOC",
label: "CPOC Name",
field: "leadAnalystName.keyword",
component: "multiSelect",
prefix: "must",
Expand All @@ -82,7 +82,7 @@ const WAIVER_FILTER_GROUP = (isCms: boolean): FilterGroup => {
value: [],
},
"planType.keyword": {
label: "Plan Type",
label: "Type",
field: "planType.keyword",
component: "multiCheck",
prefix: "must",
Expand Down Expand Up @@ -114,15 +114,15 @@ const WAIVER_FILTER_GROUP = (isCms: boolean): FilterGroup => {
value: { gte: undefined, lte: undefined },
},
raiReceivedDate: {
label: "RAI Response Date",
label: "Formal RAI Response",
field: "raiReceivedDate",
component: "dateRange",
prefix: "must",
type: "range",
value: { gte: undefined, lte: undefined },
},
"leadAnalystName.keyword": {
label: "CPOC",
label: "CPOC Name",
field: "leadAnalystName.keyword",
component: "multiSelect",
prefix: "must",
Expand Down
2 changes: 1 addition & 1 deletion src/services/ui/src/components/Opensearch/Table/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ export const OsTable: FC<{
<UI.TableRow className="h-10">
<UI.TableCell className="flex">
<p className="font-medium whitespace-nowrap h-[20px]"> </p>
<p className="absolute right-[50%] top-[50%] translate-x-[50%] translate-y-[50%] font-medium text-lg text-gray-500">
<p className="absolute right-[50%] translate-x-[50%] translate-y-[50%] font-medium text-lg text-gray-500">
No Results Found
</p>
</UI.TableCell>
Expand Down

0 comments on commit 6f41456

Please sign in to comment.