Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently WIP because:
$(location)
and$(rootpath)
make vars aren't working correctlyPYTHON_COVERAGE_TARGET
variable, which was ultimately not accepted. See also next point.coverage_tool
attribute topy_runtime
. bazelbuild/bazel#15590, and is probably better to use than the$(rootpath)
andpip_install
solution we're showing herepython
module. I confirmed this by looking throughPYTHON_PATH
pip_install
), this requires a python on the host, so there's a decent chance it won't workcoverage_tool
attribute topy_runtime
. bazelbuild/bazel#15590 merged, which currently is only available in prereleases