Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: document noninteractive flow + minor tweaks #42

Merged
merged 4 commits into from
Aug 27, 2024

Conversation

jayconrod
Copy link
Contributor

  • Squashed "One-time setup" and "Installation" headings.
  • Expanded Use section, removed "Each day".
  • Add "Use in a non-interactie environment" section.
  • Moved "Building" section up, renamed "Building from source",
    added instructions for Bazel and Go dev builds.

- Squashed "One-time setup" and "Installation" headings.
- Expanded Use section, removed "Each day".
- Add "Use in a non-interactie environment" section.
- Moved "Building" section up, renamed "Building from source",
  added instructions for Bazel and Go dev builds.
1. Download the appropriate binary from the latest [release
page](https://github.com/EngFlow/auth/releases/latest)
page](https://github.com/EngFlow/auth/releases/latest).
Copy link
Contributor

@rogerhu rogerhu Aug 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because we're not signing engflow_auth, we would need to do for MacOS binaries:

xattr -d com.apple.quarantine engflow_auth_macos_arm64
chmod u+x engflow_auth_macos_arm64

@minor-fixes fyi

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added that xattr -d command. We do need to get that binary signing to work though.

```bash
engflow_auth logout [CLUSTER URL]
```

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe link to an example of how it is set up? https://github.com/EngFlow/auth/blob/main/.github/workflows/main.yml#L57

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added links.

@jayconrod jayconrod merged commit cb34acd into main Aug 27, 2024
5 checks passed
@jayconrod jayconrod deleted the jay-doc-noninteractive branch August 27, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants