buildstamp: Fix "official" build stamping #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes the logic for "official build" labeling in buildstamp logic. Before this change, only builds from the branch `master` were official; this was erroneous since this repo uses `main` as the trunk branch name. This change validates the branch name against `main` and release branch patterns using a regexp, since technically official builds could come from release branches as well. Tested: Created a temp local branch matching the release branch pattern, and checked that a build was marked official: ``` [blackbird | ~/dev/engflow.com/auth] (release/v0.0) scott-> bazel run --stamp //cmd/engflow_auth -- version INFO: Writing tracer profile to '/home/scott/.cache/bazel/_bazel_scott/b3a8ca38e37ded8f1e329b8939d3f3df/command.profile.gz' INFO: Analyzed target //cmd/engflow_auth:engflow_auth (0 packages loaded, 0 targets configured). INFO: Found 1 target... Target //cmd/engflow_auth:engflow_auth up-to-date: bazel-bin/cmd/engflow_auth/engflow_auth_/engflow_auth INFO: Elapsed time: 0.458s, Critical Path: 0.22s INFO: 4 processes: 1 internal, 3 linux-sandbox. INFO: Build completed successfully, 4 total actions INFO: Running command line: bazel-bin/cmd/engflow_auth/engflow_auth_/engflow_auth version build time: 2024-07-23 13:33:52 -0400 EDT official build: true build branch: release/v0.0 build revision: 742a795ba209ebdff9d3ce70d7ecdd727f3ea3de clean build: true ``` Bug: linear/CUS-358
jayconrod
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes the logic for "official build" labeling in buildstamp logic. Before this change, only builds from the branch
masterwere official; this was erroneous since this repo usesmainas the trunk branch name.This change validates the branch name against
mainand release branch patterns using a regexp, since technically official builds could come from release branches as well.Tested: Created a temp local branch matching the release branch pattern, and checked that a build was marked official:
Bug: linear/CUS-358