pr feedback

internal/browser/browser.go

@@ -29,33 +29,38 @@ type Opener interface {
 type StderrPrint struct{}
 
 func openURL(url string) error {
-	var err error
 	switch runtime.GOOS {
 	case "darwin": // macOS
-		err = exec.Command("open", url).Start()
+		return exec.Command("open", url).Run()
 	case "linux":
 		providers := []string{"xdg-open", "x-www-browser", "www-browser"}
 
 		// There are multiple possible providers to open a browser on linux
 		// One of them is xdg-open, another is x-www-browser, then there's www-browser, etc.
 		// Look for one that exists and run it
 		for _, provider := range providers {
-			if _, err := exec.LookPath(provider); err == nil {
-				err = exec.Command(provider, url).Start()
+			if bin_path, err := exec.LookPath(provider); err == nil {
+				err = exec.Command(bin_path, url).Run()
+				if err == nil {
+					return nil
+				}
 			}
 		}
+		return fmt.Errorf("unsupported platform")
 	case "windows":
-		err = exec.Command("rundll32", "url.dll,FileProtocolHandler", url).Start()
+		return exec.Command("rundll32", "url.dll,FileProtocolHandler", url).Run()
 	default:
-		err = fmt.Errorf("unsupported platform")
+		return fmt.Errorf("unsupported platform")
 	}
-	return err
 }
 
 func (p *StderrPrint) Open(u *url.URL) error {
 	fmt.Fprintf(
-		os.Stdout,
-		"Opening the following URL in your web browser to authenticate:\n\n\t%s\n\n",
+		os.Stderr,
+		`Attempting to automaticaly open the authentication URL in your web browser.
+If the browser does not open or you wish to use a different device to authorize this request, open the following URL:
+		%s
+`,
 		u,
 	)
 	openURL(u.String())