Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust/Changed in EMI and EMB #30

Merged
merged 8 commits into from
Oct 16, 2024
Merged

Adjust/Changed in EMI and EMB #30

merged 8 commits into from
Oct 16, 2024

Conversation

JulStraus
Copy link
Member

This PR adjusts the package based on EnergyModelsBase v0.8.1 and EnergyModelsInvestments v0.8.0.

These changes are

  • increase of dependencies (including Julia 1.10 to switch to LTS),
  • changed the investment tests to adjust for the time profiles,
  • and replaced EMB.multiple with scale_sp_op.

hellemo
hellemo approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@hellemo hellemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I believe we can explicitly use the LTS release for CI, might be a bit easier to understand when someone looks into it (assuming we generally want to support the LTS, we made an exception for 1.9 due to extensions I believe).

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@JulStraus JulStraus merged commit 498e178 into main Oct 16, 2024
5 checks passed
@JulStraus JulStraus deleted the adjust/emi_emb branch October 16, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hellemo hellemo hellemo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JulStraus @hellemo