Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the discussion in pull request #47, this is a first take on restructuring the overall function flow. At the moment, I only focused on the variable creation to simplify it, but I think it could be beneficial to think as well of the objective function and the functions for creating nodes and links as well as calculating the emission balance. The latter would be an answer to Issue #37.
There are a few things I would like to highlight in the PR:
variables_node
tovariables_element
, but I thought it is preferable to keep at the time being the backwards compatibility intact. Changing this would allow us to remove the number of functions, but would result in a breaking change. It would however be simple to provide a function to translate the current name into the new name.!!! note
and!!! tip
.