Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to skip all checks when creating model. #39

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Conversation

hellemo
Copy link
Member

@hellemo hellemo commented Sep 17, 2024

Several of the checks fail when used with ParametricOptInterface.

We may of course consider improving the checks, but I thinks allowing to override all checks would be useful anyways. This is just a quick implementation with no warning, we can discuss improvements.

Copy link
Member

@JulStraus JulStraus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me to offer the possibility. Note that we in the current situation only allow this without EMG, not with EMB. I added a warning as I consider it highly dangerous if people do not know what they are doing.

@JulStraus JulStraus added the enhancement New feature or request label Sep 18, 2024
@hellemo hellemo merged commit 98a4b71 into main Sep 30, 2024
5 checks passed
@JulStraus JulStraus deleted the lh/skip_all_checks branch September 30, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants