Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name emissions constraints to allow for emissions extensions #36

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

JulStraus
Copy link
Member

The current version does not allow changes in the calculation of the total emissions. This leads to issues if one wants to add emissions to, e.g., transmission modes or links as outlined in Issue #9 of EnergyModelsGeography.

As we did not manage to follow up the

abstract type TransmissionMode <: EMB.Link

approach in time, it is necessary to incorporate the "hacky" solution

@JulStraus JulStraus added the enhancement New feature or request label Aug 20, 2024
@JulStraus JulStraus requested a review from hellemo August 20, 2024 08:31
@hellemo hellemo changed the title Include potential for emissions extensions Name emissions constraints to allow for emissions extensions Aug 20, 2024
Copy link
Member

@hellemo hellemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, should we have an issue to track the abstract type TransmissionMode <: EMB.Link?

I renamed the PR to make it more clear what it does (for release notes and future reference).

@JulStraus
Copy link
Member Author

LGTM, should we have an issue to track the abstract type TransmissionMode <: EMB.Link?

I renamed the PR to make it more clear what it does (for release notes and future reference).

We have an issue in EMG, but it would make sense to include one as well in EMB in my opinion. However, the key changes remain in EMG as far as I can see it.

@JulStraus JulStraus merged commit 5ed7c6d into main Aug 20, 2024
5 checks passed
@JulStraus JulStraus deleted the enhanc/trans_emissions branch August 20, 2024 08:46
@JulStraus
Copy link
Member Author

Started the issue #37 to highlight the necessity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants