feat(wallet-mobile): Add slide in and out animations #3791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stackchain
reviewed
Jan 20, 2025
| }, [fadeIn, fadeOut]) | ||
|
|
||
| React.useEffect(() => { | ||
| // When executed without setTimeout, the animation does not start |
There was a problem hiding this comment.
2 guesses here, probably mounting issue, try to wrap the fadeIn within the useLayoutEffect it should work, otherwise you can leverage -> requestAnimationFrame as well.
There was a problem hiding this comment.
This works well now, thanks!
stackchain
reviewed
Jan 20, 2025
Comment on lines
30
to
31
| const fadeInTimeout = setTimeout(() => fadeIn(), 1) | ||
| return () => clearTimeout(fadeInTimeout) |
There was a problem hiding this comment.
Suggested change
| const fadeInTimeout = setTimeout(() => fadeIn(), 1) | |
| return () => clearTimeout(fadeInTimeout) | |
| fadeIn() |
There was a problem hiding this comment.
needs testing, cuz if its not an issue on mounting, better run with InteractionManager or requestAnimationFrame.
Screen.Recording.2025-01-20.at.14.16.58.mov |
stackchain
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Change(s) / Related issue(s)
Add toast notification animations
Ticket
YV-199