feat(wallet-mobile): Add remote notifications #3744
Conversation
…/yoroi into feat/remote-notifications
| "react-native-pager-view": "^6.2.0", | ||
| "react-native-paper": "4.12.8", | ||
| "react-native-permissions": "^3.8.0", | ||
| "react-native-permissions": "^5.2.1", |
There was a problem hiding this comment.
Updated to latest version
| @@ -316,5 +319,14 @@ | |||
| "compilerOptions": { | |||
| "module": "commonjs" | |||
| } | |||
| } | |||
| }, | |||
| "reactNativePermissionsIOS": [ | |||
There was a problem hiding this comment.
This is not specified in Podfile anymore
| filePath = [[NSBundle mainBundle] pathForResource:@"GoogleService-Info-Nightly" ofType:@"plist"]; | ||
| } else { | ||
| filePath = [[NSBundle mainBundle] pathForResource:@"GoogleService-Info-Production" ofType:@"plist"]; |
There was a problem hiding this comment.
Notifications on iOS may need to be tested on nightly as iOS notifications don't work in dev mode
|
@stackchain this PR is pretty much ready, but let's leave the PR there until we release 5.2.0 to avoid any merge conflicts or unnecessary reverts |
michaeljscript
changed the title
michaeljscript
changed the title
michaeljscript
changed the title
|
Should be good to merge now |
| @@ -6,5 +6,5 @@ import {useStrings} from '../../common/useStrings' | |||
|
|
|||
| export const OpenDeviceAppSettingsButton = (props: Omit<ButtonProps, 'title' | 'onPress' | ''>) => { | |||
There was a problem hiding this comment.
It seems to have been redundant
| { | ||
| "project_info": { | ||
| "project_number": "1028338182097", | ||
| "project_id": "yoroi-mobile-dev-1", |
There was a problem hiding this comment.
maybe it should be renamed away from it looks like the other part is proddev-1
There was a problem hiding this comment.
Good point, this file should be deleted. It's an artifact from testing
| { | ||
| "project_info": { | ||
| "project_number": "526970676782", | ||
| "project_id": "yoroi-mobile-99140", |
There was a problem hiding this comment.
I've switched to dev project, instead of using dev app in prod project
| "client_info": { | ||
| "mobilesdk_app_id": "1:526970676782:android:ca69aadf225bb5e1a021bf", | ||
| "android_client_info": { | ||
| "package_name": "com.emurgo.dev" |
There was a problem hiding this comment.
here is dev, yet 99140 looks prod.
There was a problem hiding this comment.
Having a look
There was a problem hiding this comment.
Updated. Also made restrictions to production keys.
Description / Change(s) / Related issue(s)
Add Android and iOS push notifications
TODO
Ticket
YV-119