Improve cache when fetching lessons #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test on Playground |
aristath
reviewed
Nov 7, 2024
classes/class-lessons.php
Outdated
| 'https://progressplanner.com/wp-json/progress-planner-saas/v1/free-lessons' | ||
| ); | ||
|
|
||
| $cache_key = 'lessons-' . $url; |
There was a problem hiding this comment.
It would probably be safer if we md5() the URL...
Suggested change
| $cache_key = 'lessons-' . $url; | |
| $cache_key = 'lessons-' . md5( $url ); |
There was a problem hiding this comment.
Sure, I left it just because of the debugging - any hash will do the job.
aristath
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Due to the way how currently our code works fetching lessons from API is done on every
init(I get it even on front end, not just in Dashboard).If request is successful the response is cached, but if it is not our server will be hammered. To prevent that I cached empty array with 5 minutes lifetime in case that request fails.
Another problem is that
$urlcan be filtered, but the cache key is never changed - meaning that even if $url is changed user will keep getting lessons which were fetched from old$urluntil the cache expires (which can be up to a week).I used
$urlin order to make$cache_keyunique and left it unchanged in order to make possible (future) debugging easier.Quality assurance