Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Slim SEO #30

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Conversation

rilwis
Copy link
Contributor

@rilwis rilwis commented Jun 21, 2024

Add support for the Slim SEO plugin, which will exclude tags with fewer than the minimum number of posts from the Slim SEO sitemap.

Slim SEO uses a similar filter as the core sitemap, thus the code is similar.

I've tested and it works as intended.

@rilwis
Copy link
Contributor Author

rilwis commented Jul 2, 2024

Hi @jdevalk @aristath , can you please take a look?

@aristath
Copy link
Member

aristath commented Jul 2, 2024

Hey there @rilwis!
Thank you for this PR, and my apologies that it took us so long to get to it... It was submitted during the WCEU weekend and we missed it 😅

  • Code looks good
  • Reviewed the code in simple-seo, and saw that the exclude arg gets passed-on to get_terms(), so this looks OK
  • Automated tests pass

cc @jdevalk

@aristath aristath requested a review from jdevalk July 2, 2024 07:02
@jdevalk
Copy link
Member

jdevalk commented Jul 2, 2024

Code looks good, tested too, works as intended.

@jdevalk jdevalk closed this in #32 Jul 2, 2024
@jdevalk jdevalk merged commit 37a881b into Emilia-Capital:develop Jul 2, 2024
11 of 12 checks passed
@rilwis
Copy link
Contributor Author

rilwis commented Jul 3, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants