Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WPCS 3.1, PHPStan and workflows #123

Merged
merged 6 commits into from
Sep 18, 2024
Merged

WPCS 3.1, PHPStan and workflows #123

merged 6 commits into from
Sep 18, 2024

Conversation

jdevalk
Copy link
Member

@jdevalk jdevalk commented Apr 5, 2024 •
edited
Loading

Context

  • Added PHPStan
  • Updated WPCS to 3.1
  • Fixed errors
  • Updated tested up to WP version
  • Update WP version matrix

Quality assurance

  • I have tested this code to the best of my abilities.
  • I have added unit tests to verify the code works as intended.
  • I have checked that the base branch is correctly set.

Fixes #

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 5, 2024 •
edited
Loading

WordPress Playground

You can easily test this pull request on the WordPress Playground, or download the zip file.

@jdevalk jdevalk requested a review from aristath April 5, 2024 20:34
aristath
aristath approved these changes Apr 5, 2024
View reviewed changes
Copy link
Member

@aristath aristath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test it, but the code looks good.
I can test it on Monday, but looks ok to merge 👌

@jdevalk jdevalk merged commit 8c95466 into develop Sep 18, 2024
14 checks passed
@jdevalk jdevalk deleted the jdv/wpcs31 branch September 18, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aristath aristath aristath approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdevalk @aristath