Fix queries to find options

Emilia-Capital · Sep 6, 2024 · 9a420c1 · 9a420c1
1 parent 69e4936
commit 9a420c1
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/aaa-option-optimizer.php b/aaa-option-optimizer.php
@@ -37,10 +37,7 @@ function aaa_option_optimizer_activation() {
 	$placeholders    = implode( ',', array_fill( 0, count( $autoload_values ), '%s' ) );
 	// phpcs:ignore WordPress.DB.DirectDatabaseQuery.DirectQuery, WordPress.DB.DirectDatabaseQuery.NoCaching -- One-time query, no caching needed.
 	$result = $wpdb->get_row(
-		$wpdb->prepare(
-			"SELECT COUNT(*) AS count, SUM(LENGTH(option_value)) AS autoload_size FROM {$wpdb->options} WHERE autoload IN ( %s )",
-			$placeholders
-		)
+		$wpdb->prepare( "SELECT count(*) AS count, SUM( LENGTH( option_value ) ) as autoload_size FROM {$wpdb->options} WHERE autoload IN ( $placeholders )", $autoload_values )
 	);
 	update_option(
 		'option_optimizer',

diff --git a/src/class-admin-page.php b/src/class-admin-page.php
@@ -287,7 +287,7 @@ function ( $value, $key ) {
 		$placeholders    = implode( ',', array_fill( 0, count( $autoload_values ), '%s' ) );
 		// phpcs:ignore WordPress.DB.DirectDatabaseQuery.NoCaching, WordPress.DB.DirectDatabaseQuery.DirectQuery
 		$result = $wpdb->get_row(
-			$wpdb->prepare( "SELECT count(*) AS count, SUM( LENGTH( option_value ) ) as autoload_size FROM {$wpdb->options} WHERE autoload IN ( %s )", $placeholders )
+			$wpdb->prepare( "SELECT count(*) AS count, SUM( LENGTH( option_value ) ) as autoload_size FROM {$wpdb->options} WHERE autoload IN ( $placeholders )", $autoload_values )
 		);
 
 		echo '<h2>' . esc_html__( 'Stats', 'aaa-option-optimizer' ) . '</h2>';